More fixes for labelmaps

Kitware / itk-vtk-viewer

2D / 3D web image, mesh, and point set viewer using itk-wasm and vtk.js

https://kitware.github.io/itk-vtk-viewer/

BSD 3-Clause "New" or "Revised" License

210 stars 64 forks source link

More fixes for labelmaps #252

Closed scottwittenburg closed 4 years ago

scottwittenburg commented 4 years ago

This PR:

[x] handles the labelmap opacity slider the way we want
[x] debounces most of the application sliders for a better user experience
[x] fixes the z-index of the categorical colormap selection component
[x] fixes tooltip positions of some of the top row buttons so they can be seen

scottwittenburg commented 4 years ago

@thewtex I still don't think I understand why the volume rendering looks the way it does when we have a label map, something still seems weird (to me) there.

Also, this PR would require a change to vtk.js unless you'd rather I just supply that pwf from the application.

Otherwise I think this addresses most of the things we discussed today. Let me know if you see something I may have missed.

scottwittenburg commented 4 years ago

Hopefully this shows off the labelmap opacity slider working the way you want, as well as highlighting how debouncing the slider actions makes them more responsive.

localhost_8080

scottwittenburg commented 4 years ago

@thewtex Just to be clear, this shouldn't be merged until we 1) either accept that vtk.js PR or create the pwf in the application, and 2) rewrite the history of this PR branch so it's clean and we get a new version.

scottwittenburg commented 4 years ago

@thewtex This is either ready for another round of review, or just merge it and the next things can happen in a new topic.

thewtex commented 4 years ago

:tada: This PR is included in version 9.21.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: