Closed scottwittenburg closed 4 years ago
@thewtex I still don't think I understand why the volume rendering looks the way it does when we have a label map, something still seems weird (to me) there.
Also, this PR would require a change to vtk.js
unless you'd rather I just supply that pwf from the application.
Otherwise I think this addresses most of the things we discussed today. Let me know if you see something I may have missed.
Hopefully this shows off the labelmap opacity slider working the way you want, as well as highlighting how debouncing the slider actions makes them more responsive.
@thewtex Just to be clear, this shouldn't be merged until we 1) either accept that vtk.js PR or create the pwf in the application, and 2) rewrite the history of this PR branch so it's clean and we get a new version.
@thewtex This is either ready for another round of review, or just merge it and the next things can happen in a new topic.
:tada: This PR is included in version 9.21.0 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
This PR: