search

Kitware / itk-vtk-viewer

2D / 3D web image, mesh, and point set viewer using itk-wasm and vtk.js
https://kitware.github.io/itk-vtk-viewer/
BSD 3-Clause "New" or "Revised" License
210 stars 64 forks source link

fix(createGeometryColorChooser): Default geometry color is red #270

Closed thewtex closed 4 years ago

thewtex commented 4 years ago

Has a good contrast with the viridis colormap used for images.

kerautret commented 4 years ago

Thanks a lot that works perfectly ;) 👍🏻

Capture d’écran 2020-04-26 à 10 51 15

kerautret commented 4 years ago

Perhaps the same edit can be done for the alpha selection ? For general use the default value can be let to 1.0 but it could a way to change it in a custom version. https://github.com/Kitware/itk-vtk-viewer/blob/master/src/UserInterface/Geometries/createGeometryOpacitySlider.js

thewtex commented 4 years ago

Perhaps the same edit can be done for the alpha selection ? For general use the default value can be let to 1.0 but it could a way to change it in a custom version. https://github.com/Kitware/itk-vtk-viewer/blob/master/src/UserInterface/Geometries/createGeometryOpacitySlider.js

Yes, could you please create a PR?

thewtex commented 4 years ago

:tada: This PR is included in version 9.22.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

kerautret commented 4 years ago

Perhaps the same edit can be done for the alpha selection ? For general use the default value can be let to 1.0 but it could a way to change it in a custom version. https://github.com/Kitware/itk-vtk-viewer/blob/master/src/UserInterface/Geometries/createGeometryOpacitySlider.js

Yes, could you please create a PR?

Yes I do it :) Thanks for this new version