search

Kitware / itk-vtk-viewer

2D / 3D web image, mesh, and point set viewer using itk-wasm and vtk.js
https://kitware.github.io/itk-vtk-viewer/
BSD 3-Clause "New" or "Revised" License
210 stars 64 forks source link

Fix issue affecting labemaps with many labels #276

Closed scottwittenburg closed 4 years ago

scottwittenburg commented 4 years ago

This PR fixes the regression with the interpolation button being enabled, even when we we have a labelmap, as well as some issues we saw last week with lots of labels seemingly getting assigned the same color, even though mouse picking could distinguish the labeled regions.

fix-issue-with-many-labels-opt

scottwittenburg commented 4 years ago

@thewtex It seems to me like this has greatly improved the volume rendering of labelmaps with many labels, so we may no longer need to get into the opacity mode fractional vs proportional stuff we discussed on Friday. But maybe you want to try out the branch and let me know what you think.

thewtex commented 4 years ago

@thewtex It seems to me like this has greatly improved the volume rendering of labelmaps with many labels,

@scottwittenburg woah, yes, much better! :clap: :1st_place_medal: We are seeing all the colors now, no artifacts :100:

we may no longer need to get into the opacity mode fractional vs proportional stuff we discussed on Friday. But maybe you want to try out the branch and let me know what you think.

This should still be useful because, as seen in this example where we have a lot of colors, but there is just a lot of clutter and no control over the overall opacity; this will provide a way to a) emphasize the content of interest, b) define the content of interest, c) define a way to control the overall opacity (we could do this in other ways, but a) and b) are even more useful).

thewtex commented 4 years ago

:tada: This PR is included in version 9.23.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: