Kitware / itk-vtk-viewer

2D / 3D web image, mesh, and point set viewer using itk-wasm and vtk.js
https://kitware.github.io/itk-vtk-viewer/
BSD 3-Clause "New" or "Revised" License
210 stars 64 forks source link

File loading functionality broken #277

Closed scottwittenburg closed 4 years ago

scottwittenburg commented 4 years ago

It seems maybe after #275 was merged, we lost the ability to drag and drop files into the viewer. Also, the fileToLoad url parameter doesn't seem to work anymore. When I try to use these features, I don't see any errors in the console, but the viewer is black and the "image" parts of the ui are not generated.

Screen Shot 2020-05-04 at 1 45 37 PM
scottwittenburg commented 4 years ago

I guess using filesToLoad isn't the way to pass a label map and image via the url anymore, as the ability to tell them apart in that situation isn't very sophisticated, and now we should use image and labelMap url parameters. However, it's still the case that simply dropping a single image file doesn't work anymore, and produces the result above.

kerautret commented 4 years ago

@scottwittenburg It is also the case in an embedded view like in the doc: https://kitware.github.io/itk-vtk-viewer/docs/viewer.html we obtain the same display... Capture d’écran 2020-05-05 à 10 19 37

thewtex commented 4 years ago

@scottwittenburg @kerautret good catch -- yes filesToLoad should still be working as before.

This is addressed in #279 .