search

Kitware / itk-vtk-viewer

2D / 3D web image, mesh, and point set viewer using itk-wasm and vtk.js
https://kitware.github.io/itk-vtk-viewer/
BSD 3-Clause "New" or "Revised" License
210 stars 64 forks source link

fix(LabelMaps): Support loading and displaying annotations #278

Closed scottwittenburg closed 4 years ago

scottwittenburg commented 4 years ago

Supports loading annotations via url parameter annotations. Example annotations file can be found here.

scottwittenburg commented 4 years ago

@thewtex, while this is basically working end-to-end, I think we'll need to iterate on it a little. For example:

  1. I can't remember if the label values correspond to the index in, e.g. allen_ontology_50.json, or if it's the id values.
  2. I show the 'acronymfield, rather than thenamefield, because of how long thename` seems to be.
  3. This does not yet support drag-and-drop annotations files.
thewtex commented 4 years ago

Looking good, thanks @scottwittenburg! I will take a closer look later on today.

scottwittenburg commented 4 years ago

@thewtex Mind taking another look when you get a chance? I think I addressed all the concerns you raised, and if we can get it merged, I would like to make use of some of this work in #282.

Thanks!

thewtex commented 4 years ago

:tada: This PR is included in version 9.24.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: