search

Kitware / itk-vtk-viewer

2D / 3D web image, mesh, and point set viewer using itk-wasm and vtk.js
https://kitware.github.io/itk-vtk-viewer/
BSD 3-Clause "New" or "Revised" License
210 stars 64 forks source link

fix(Viewer): Make labelmap component proportional in volume rendering #282

Closed scottwittenburg closed 4 years ago

scottwittenburg commented 4 years ago

Needs this change from vtk.js.

proportional-component-optimize

scottwittenburg commented 4 years ago

@thewtex This is still missing that extra multiplier you described, and isn't tested other than with the zarr-ized ccf. So let's iterate on it a bit before we decide?

scottwittenburg commented 4 years ago

@thewtex I couldn't get everything done tonight, but here's a video showing the latest:

per-label-weighting

thewtex commented 4 years ago

@scottwittenburg I am going to start integrating at least the click selection functionality into Jupyter -- would you please factor out the clickCallback improvements here into a separate commit that can be merged while working out the opacity details? In the process it would be best to have a subscribe interface so we can have two callbacks registered -- updating the selected label map and sending the last clicked data down to Python.

scottwittenburg commented 4 years ago

@thewtex I think this is ready for review. As it turned out, enhancing the label select wasn't easy and straightforward, so I wanted to defer that until we come up with a better UI for managing those per-label weights. I think I addressed the other items we discussed friday.

Next PR will update the event subscription infrastructure and expose the API we'll need to embed the viewer as a value widget in a Jupyter notebook.

thewtex commented 4 years ago

:tada: This PR is included in version 9.24.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: