search

Kitware / itk-vtk-viewer

2D / 3D web image, mesh, and point set viewer using itk-wasm and vtk.js
https://kitware.github.io/itk-vtk-viewer/
BSD 3-Clause "New" or "Revised" License
210 stars 64 forks source link

ci(GraphicalTests): Re-enable #283

Closed thewtex closed 4 years ago

thewtex commented 4 years ago

Tests were failing with false positives due to Firefox 75. Firefox 76 is now out.

thewtex commented 4 years ago

Closes #260

thewtex commented 4 years ago

@floryst running into

> karma start ./karma.conf.js --browsers Chrome,Firefox "--browsers" "Firefox"

sh: 1: karma: not found

but just for Node 12. Does this ring a bell? :bell: :sound:

floryst commented 4 years ago

Yeah, that's due to needle having issues right now with last node 12 version. You can install request as a dev dependency as a workaround.

thewtex commented 4 years ago

@floryst :1st_place_medal: thanks!

thewtex commented 4 years ago

:tada: This PR is included in version 9.24.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: