search

Kitware / itk-vtk-viewer

2D / 3D web image, mesh, and point set viewer using itk-wasm and vtk.js
https://kitware.github.io/itk-vtk-viewer/
BSD 3-Clause "New" or "Revised" License
210 stars 64 forks source link

Use jsdelivr for CDN #378

Open thewtex opened 3 years ago

thewtex commented 3 years ago

https://www.jsdelivr.com/

Appears to be more production-oriented than Unpkg

thewtex commented 2 years ago

Local testing works, need to update doc's.

thewtex commented 2 years ago

@PaulHax with #485 does the CDN bundle still work? Can it be updated to use jsdelivr?

PaulHax commented 2 years ago

485 does not change the publicPath for the itkVtkViewerCDN.js webpack target... But how to mock a jsdeliver setup for that branch?

You already setup webpack to use jsdeliver methinks...

thewtex commented 2 years ago

You already setup webpack to use jsdeliver methinks...

Hmm, it seems so. :roll_eyes: Good job past me :-).

I see we have __itk_version__:

https://github.com/Kitware/itk-vtk-viewer/blob/8084f37fdb2a471258bf380f31b5867de5097989/src/itkConfigCDN.js#L7-L8

But in recent itk-wasm, we are decoupling the itk-*-io package version from the main itk-wasm package. So, I will keep this issue open for now.