search

Kitware / itk-vtk-viewer

2D / 3D web image, mesh, and point set viewer using itk-wasm and vtk.js
https://kitware.github.io/itk-vtk-viewer/
BSD 3-Clause "New" or "Revised" License
210 stars 64 forks source link

feat(ImJoy): Support setPointSets #408

Closed oeway closed 3 years ago

oeway commented 3 years ago

This PR allows displaying point cloud with the ImJoy API.

Fixes https://github.com/Kitware/itk-vtk-viewer/issues/407

oeway commented 3 years ago

@thewtex One of the tests is failing and I have no idea how to fix it. Please take a look.

Another question is about the Plane Index Slider, how do we disable that for pointSets?

Screenshot 2021-06-24 at 11 50 27
thewtex commented 3 years ago

@oeway awesome work!! 🌟 ☁️ 🌻

@thewtex One of the tests is failing and I have no idea how to fix it. Please take a look.

We just have to bump the expected number of tests from 5 to 6 here:

https://github.com/Kitware/itk-vtk-viewer/blob/718ad2b482f2a30ee5556b24f45cc5c18b7a8348/test/imjoyTest.js#L53

Another question is about the Plane Index Slider, how do we disable that for pointSets?

In progress, but the planes will be used to clip the point sets so you can interactively "look" into them.

oeway commented 3 years ago

Thank you!

I see! I tried the plane index slider, it doesn’t seem to have any effect. In any case it might be good to provide a function to disable it.

On Thu 24 Jun 2021 at 23:49, Matt McCormick @.***> wrote:

@oeway https://github.com/oeway awesome work!! 🌟 ☁️ 🌻

@thewtex https://github.com/thewtex One of the tests is failing and I have no idea how to fix it. Please take a look.

We just have to bump the expected number of tests from 5 to 6 here:

https://github.com/Kitware/itk-vtk-viewer/blob/718ad2b482f2a30ee5556b24f45cc5c18b7a8348/test/imjoyTest.js#L53

Another question is about the Plane Index Slider, how do we disable that for pointSets?

In progress, but the planes will be used to clip the point sets so you can interactively "look" into them.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/Kitware/itk-vtk-viewer/pull/408#issuecomment-867974156, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADU3SZCMHLO2SVTXUGOU4TTUOR75ANCNFSM47HM3TOQ .

oeway commented 3 years ago

@thewtex I would like to display several pint sets, and I am wondering how we can specify the color for each set.

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 11.5.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: