search

Kitware / itk-vtk-viewer

2D / 3D web image, mesh, and point set viewer using itk-wasm and vtk.js
https://kitware.github.io/itk-vtk-viewer/
BSD 3-Clause "New" or "Revised" License
209 stars 63 forks source link

fix(createViewer): Handle TAKE_SCREENSHOT event #669

Closed thewtex closed 1 year ago

thewtex commented 1 year ago

To address with itkwidgets:

caught Error: Unexpected event type: TAKE_SCREENSHOT
    at itkVtkViewer.js:161:457719
    at itkVtkViewer.js:2:1470699
    at Set.forEach (<anonymous>)
    at Object.send (itkVtkViewer.js:2:1470671)
    at e.sendTo (itkVtkViewer.js:2:1457639)
    at e._exec (itkVtkViewer.js:2:1458205)
    at e.exec (itkVtkViewer.js:2:1467591)
    at e.execute (itkVtkViewer.js:2:1459688)
    at e.update (itkVtkViewer.js:2:1460057)
    at itkVtkViewer.js:2:1457049
thewtex commented 1 year ago

In itkwidgets, we take a screenshot by default after initial rendering and this is saved in the notebook output cell so when browsing on GitHub, etc. there is a rendering in the notebook.

I am wondering if this errors ends putting the viewer in an invalid state. Subsequent view commands can be unresponsive.

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 14.36.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: