Less peak memory for Compare wasm - Githubissues

Kitware / itk-vtk-viewer

2D / 3D web image, mesh, and point set viewer using itk-wasm and vtk.js

https://kitware.github.io/itk-vtk-viewer/

BSD 3-Clause "New" or "Revised" License

209 stars 63 forks source link

Less peak memory for Compare wasm #675

Closed PaulHax closed 1 year ago

PaulHax commented 1 year ago

Setting ReleaseDataFlagOn() for filters enables checkerboard compare for this dataset:

http://localhost:8082/?rotate=false&image=https://aind-open-data.s3.us-west-2.amazonaws.com/SmartSPIM_000393_2023-01-06_13-35-10_stitched_2023-02-02_22-28-35/processed/OMEZarr/Ex_445_Em_469.zarr&fixedImage=https://aind-open-data.s3.us-west-2.amazonaws.com/SmartSPIM_000393_2023-01-06_13-35-10_stitched_2023-02-02_22-28-35/processed/OMEZarr/Ex_445_Em_469.zarr&compare=checkerboard

Closes #674

thewtex commented 1 year ago

Could need addition Update() calls for the AwSnap?

Need to call ReleaseDataOn() (spelling?) on the intermediate filters for the memory to be released.

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 14.38.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: