search

Kitware / itk-vtk-viewer

2D / 3D web image, mesh, and point set viewer using itk-wasm and vtk.js
https://kitware.github.io/itk-vtk-viewer/
BSD 3-Clause "New" or "Revised" License
205 stars 62 forks source link

fix(zarrmultiscalespatialimage): support Zarr stores not ending in .zarr #721

Closed berombau closed 8 months ago

berombau commented 9 months ago

The isZarr regex was updated to support .zarr/image, besides just .zarr and DANDI /zarr/.

fix #719

PaulHax commented 9 months ago

Awesome! One more little ask. These tests are failing: https://github.com/Kitware/itk-vtk-viewer/blob/master/test/zarrTest.js#L43-L49

Perhaps we can add another bit to the regex to fix?

PaulHax commented 9 months ago

On second though, some of those failing tests are silly. I made a couple tweeks to your PR here: https://github.com/berombau/itk-vtk-viewer/pull/1

Maybe we can incopreate then I'll merge and deploy.

thewtex commented 8 months ago

@berombau if it looks good, could you please merge @PaulHax 's pull request on your pull request? https://github.com/berombau/itk-vtk-viewer/pull/1

berombau commented 8 months ago

@PaulHax @thewtex is it good like this? Do I need to do anything else?

PaulHax commented 8 months ago

Much thanks.

github-actions[bot] commented 8 months ago

:tada: This PR is included in version 14.47.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: