Save session as item metadata instead of json file

Kitware / minerva

Minerva: client/server/services for analysis and visualization

Apache License 2.0

36 stars 14 forks source link

Save session as item metadata instead of json file #319

Closed mgrauer closed 8 years ago

mgrauer commented 8 years ago

This changes the Session model to save its Minerva metadata in the Girder Item metadata, just as with the other models.

Note that to QA this and once this goes in, you'll have to delete all of the Items in your Girder user's minerva/session folder as they are incompatible.

@jbeezley PTAL.

Fixes #317.

mgrauer commented 8 years ago

That was just plain weird. Added the missing *.

jbeezley commented 8 years ago

This is much better! Other than my concern about event names, this LGTM.

jbeezley commented 8 years ago

If you want to tackle de-namespacing the events later, then this LGTM now.

mgrauer commented 8 years ago

@jbeezley

I tried different combos of triggers/listeners and only could ever see a one-to-one correspondence. Clearly I don't understand this, and you have convinced me to stay away from event namespaces entirely.

I thoroughly tested this de-namespacing commit.

I can:

create/list/rename/delete/view sessions
display new or existing geojson
display new or existing contour json
display new or existing choropleth
display new or existing mongo
display new or existing wms

jbeezley commented 8 years ago

Does this help? http://jsbin.com/ralago/edit?js,console

jbeezley commented 8 years ago

LGTM

mgrauer commented 8 years ago

That helps, thanks. Backbone always treats them as a literal string.