search

Kitware / minerva

Minerva: client/server/services for analysis and visualization
Apache License 2.0
36 stars 14 forks source link

Minerva without romanesco #356

Closed dorukozturk closed 8 years ago

dorukozturk commented 8 years ago

This PR decouples Romanesco from Minerva.

aashish24 commented 8 years ago

Congrats on your very first PR :tada:

aashish24 commented 8 years ago

This branch seems very close. I just did git grep romanesco and found few other places (in documentation and in ansible) that we could clean up as well. I am fine with taking care of ansible in other branch.

kotfic commented 8 years ago

@dorukozturk All "spark" related code will also need to be removed as this exclusively depended on the mean_contour analysis. Please also remove all analyses in the analyses/ folder as these are romanesco analyses. Please also take a look at the .travis.yml and make sure no romanesco/spark related things are being installed for continuous integration tests.

Thanks!

dorukozturk commented 8 years ago

@aashish24 Thank you very much. I did not want to play with the ansible scripts not to break it. @kotfic That will be my next task.

aashish24 commented 8 years ago

@dorukozturk thanks for removing other pieces as well. I will have a look at it today.

aashish24 commented 8 years ago

@dorukozturk I didn't try the ansible / vagrant, other changes :+1:

aashish24 commented 8 years ago

LGTM :+1: