Kitware / minerva

Minerva: client/server/services for analysis and visualization
Apache License 2.0
36 stars 14 forks source link

Update girder for upstream deployment fixes #371

Closed jbeezley closed 8 years ago

jbeezley commented 8 years ago

Ping. I think I finally have a working version here.

mgrauer commented 8 years ago

I thought we had removed the dependence on Romanesco?

I assume that this failure you are fixing was for the girder-worker core plugin in girder. Could we also fix it by adding the girder-worker to the

 - export IGNORE_PLUGINS=

line in .travis.yml?

I'm fine with whatever you do, asking to understand it better.

mgrauer commented 8 years ago

LGTM

jbeezley commented 8 years ago

You're right we could remove girder_worker, but this update was necessary to bring the fontello fix from girder. https://github.com/girder/girder/pull/1550