Add geoviz support - Githubissues

Kitware / minerva

Minerva: client/server/services for analysis and visualization

Apache License 2.0

36 stars 14 forks source link

Add geoviz support #377

Closed jbeezley closed 7 years ago

jbeezley commented 7 years ago

This branch still contains a few changes necessary for the GeoViz plugin.

Append authentication headers
Add an event that is fired after the application starts
Load extra javascript sources at load
Override adapter method for a dataset

aashish24 commented 7 years ago

@jbeezley I fixed the server side tests but still having issues on client side testing. I can push a fix, do you have any insight?

Also, I local test this branch and it it looking ok, should we merge it after test fixes?

aashish24 commented 7 years ago

thanks for the client side fixes @jbeezley. Is this ready to be merged or do we have some more work that needs to be done?

jbeezley commented 7 years ago

It's probably overdue to be merged. We can make new PR's for further updates.

aashish24 commented 7 years ago

It's probably overdue to be merged. We can make new PR's for further updates.

Sounds good to me @jbeezley I have been doing local testing and other than some minor issues (which can be taken care in next PR's) it LGTM 👍 Please go ahead and merge it. It looks good