search

Kitware / minerva

Minerva: client/server/services for analysis and visualization
Apache License 2.0
36 stars 14 forks source link

Girder 2 migration #415

Closed matthewma7 closed 7 years ago

matthewma7 commented 7 years ago

Upgrade Minerva project to work with latest master girder.

Special thanks to @jbeezley for helping with the migration.

matthewma7 commented 7 years ago

This is ready for review.

aashish24 commented 7 years ago

@manthey could you please review this branch?

aashish24 commented 7 years ago

@manthey @dorukozturk could you please review this branch?

dorukozturk commented 7 years ago

@matthewma7 I was able to get it up and running with Girder 2. Also bunch of unused code is deleted which is nice. I will try to do a second pass on this diving a little deeper.

matthewma7 commented 7 years ago

@dorukozturk, Cool, Thank you. 😃

matthewma7 commented 7 years ago

@manthey, thank you for reviewing this PR. As discussed, the eslint for the external test is not included at this moment. This is ready for further reviews.