search

Kitware / minerva

Minerva: client/server/services for analysis and visualization
Apache License 2.0
36 stars 14 forks source link

Dataset download api endpoint #420

Closed matthewma7 closed 7 years ago

matthewma7 commented 7 years ago

Minerva core and it's dependent like gaia minerva are using girder file download API endpoint to get the data of Minerva Dataset. However, with the introduction of Postgres on-the-fly geometry linking dataset, the existing girder file download API is not supporting downloading of such dataset because the data needs on-the-fly processing. We should unify the downloading interface of all Minerva dataset. Monkey patching file/download api is cumbersome and error prone. Also, as Minerva dataset are getting more complex, it makes sense to build Minerva Dataset specific API instead of work around girder concepts. So, this PR creates minerva_dataset/download API to replace the role of file/download endpoint. This new endpoint output geojson download no matter it is a GeoJSON dataset or Postgres geometry linking dataset.

matthewma7 commented 7 years ago

This is ready for review.

aashish24 commented 7 years ago

@matthewma7 is this ready for review?

matthewma7 commented 7 years ago

@aashish24 Yes, it's ready for review.

matthewma7 commented 7 years ago

@aashish24 Thanks!