search

Kitware / minerva

Minerva: client/server/services for analysis and visualization
Apache License 2.0
36 stars 14 forks source link

Dataset sharing #453

Closed matthewma7 closed 6 years ago

matthewma7 commented 6 years ago

This PR adds dataset sharing based on Girder public folder structure.

2017-11-01_12-33-50

matthewma7 commented 6 years ago

This is ready for some review.

aashish24 commented 6 years ago

@matthewma7 how do I test it? Create another user? Also, it would be great if we can add some tests as well (I am okay with if that goes in another PR)

matthewma7 commented 6 years ago

@aashish24 Yes, I don't see roadblock to for testing this feature. It is the time to familiarize myself with girder testing infrastructure. I think we could create a subsequent PR for it. To test this PR, you could create a different user B, once the user A shares a dataset, it should be available to user B.

aashish24 commented 6 years ago

@aashish24 Yes, I don't see roadblock to for testing this feature. It is the time to familiarize myself with girder testing infrastructure. I think we could create a subsequent PR for it.

+1 lets do that in a separate PR

aashish24 commented 6 years ago

To test this PR, you could create a different user B, once the user A shares a dataset, it should be available to user B.

okay will do that

matthewma7 commented 6 years ago

@aashish24 Thank you for reviewing this PR. 👌