search

Kitware / minerva

Minerva: client/server/services for analysis and visualization
Apache License 2.0
36 stars 14 forks source link

Remove unused and abandoned code #464

Closed aashish24 closed 6 years ago

aashish24 commented 6 years ago

Fixes #463 #461

aashish24 commented 6 years ago

@matthewma7 the WMS portion of code is not clear to me. I think WMS code needs some decent fixing. I am wondering if we should remove the code now and add it back later if we need it. I do not think currently we need it for any active project. thoughts? I or you may have to push more code to remove traces of WMS

matthewma7 commented 6 years ago

@aashish24 I am not really certain about the WMS code. I would like to ask, @jbeezley, does the WMS imported dataset in BSVE use any of these codes?

jbeezley commented 6 years ago

BSVE reference layers derive from WMS layers, but I don't think it relies on this specific code, which is just the "Add a WMS layer" button.

aashish24 commented 6 years ago

Thanks @jbeezley @matthewma7