search

Kitware / minerva

Minerva: client/server/services for analysis and visualization
Apache License 2.0
36 stars 14 forks source link

Refactor adapters #469

Closed matthewma7 closed 6 years ago

matthewma7 commented 6 years ago

The GeoJS adapters in Minerva are all in one single file in Minerva and they use custom utility library for inheritance. This PR separate them into different files and uses es6 language feature for inheritance. This makes the more standard and easier to understand and have some theoretical improvement in speed and memory usage.

aashish24 commented 6 years ago

this is huge win, thanks this is very much appreciated. @manthey @jbeezley your input here will be very useful. I will have a detailed look sometime next week.

matthewma7 commented 6 years ago

@manthey @aashish24 Thanks 👌