Kitware / minerva

Minerva: client/server/services for analysis and visualization
Apache License 2.0
36 stars 14 forks source link

Minerva docker girder 2 upgrade #475

Closed matthewma7 closed 6 years ago

matthewma7 commented 6 years ago

This PR cherrypicked changes needed to make girder 2 upgrade work in Minerva docker project

codecov-io commented 6 years ago

Codecov Report

Merging #475 into master will decrease coverage by 0.92%. The diff coverage is 53.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #475      +/-   ##
==========================================
- Coverage   45.27%   44.35%   -0.93%     
==========================================
  Files          71       72       +1     
  Lines        3408     3506      +98     
  Branches      288      297       +9     
==========================================
+ Hits         1543     1555      +12     
- Misses       1865     1951      +86
Impacted Files Coverage Δ
web_external/views/map/MapPanel.js 44.64% <ø> (ø) :arrow_up:
web_external/views/body/DataPanel.js 29.29% <0%> (ø) :arrow_up:
web_external/views/adapters/registry.js 76.47% <100%> (+1.47%) :arrow_up:
web_external/main.js 100% <100%> (ø) :arrow_up:
web_external/views/body/analysisWidgetRegistry.js 25% <33.33%> (ø) :arrow_up:
web_external/views/widgets/FeatureInfoWidget.js 16.88% <50%> (+1.09%) :arrow_up:
...eb_external/views/widgets/StyleWmsDatasetWidget.js 8.42% <0%> (ø)
web_external/router.js 80% <0%> (+5%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e031365...f1a6d7c. Read the comment docs.

matthewma7 commented 6 years ago

@manthey Thanks!