search

Kitware / minerva

Minerva: client/server/services for analysis and visualization
Apache License 2.0
36 stars 14 forks source link

Draw boundary dataset and boundary filtering #479

Closed matthewma7 closed 6 years ago

matthewma7 commented 6 years ago

Utilize GeoJS annotation layer for boundary dataset creating. Uses bounding box support based on the previous PRs for intersecting filtering.

2017-12-14_13-11-32

manthey commented 6 years ago

When you delete a boundary that was used to filter, should the filter be turned off?

manthey commented 6 years ago

When you are in draw-boundary mode, can you change the draw icon so that it shows it is selected?

matthewma7 commented 6 years ago

@manthey Thank you for your review. I think it's ok not to remove the boundary when the dataset is removed? I think the icon could have changed to indicate it's drawing mode, but I did some new feature related to icons. So, I think I will add it in a following PR.

When testing, I found out the boundary calculation is not supported on WMS layers, so I added a series of check and message to handle the situation when boundary can't be acquired.

manthey commented 6 years ago

If it wouldn't be too much work, can you add a test with a dataset where you can't get bounds? Otherwise, this looks good.

matthewma7 commented 6 years ago

Thank you @manthey for reviewing 🍺