search

Kitware / minerva

Minerva: client/server/services for analysis and visualization
Apache License 2.0
36 stars 14 forks source link

Gaia and girder-worker integration #481

Closed matthewma7 closed 6 years ago

matthewma7 commented 6 years ago

Gaia was a third party dependency for Minerva. Before this PR, Gaia can be used in Minerva with the plugin gaia-minerva and based on an analysis registering mechanism. This PR integrates Gaia-minerva into Minerva, making gaia a dependancy of Minerva. This PR also introduce girder-worker to this project. Girder-worker runs Gaia analysis process remotely.

This PR utilize selection feature of datapanel. This PR applies default values as gaia parameter based on user selection.

Note: Some of the gaia process is resulting in some errors but it's consistent with the previous state, so I would like to ask to look into those in a separate PR. The Minerva server has an endpoint (originally from gaia-minerva) based on some introspection of gaia, so the server became depending on Gaia as well.

2018-01-09_12-19-05

aashish24 commented 6 years ago

@matthewma7 is this ready for review?

matthewma7 commented 6 years ago

@aashish24 Yes, I think @jbeezley may have looked at it already. Since the corresponding change in minerva-docker depends on this. I think we could possibly merge this one first.

jbeezley commented 6 years ago

I'm looking at it now.

matthewma7 commented 6 years ago

Hi @jbeezley, I updated code to use girder-worker config, could you take another look?

matthewma7 commented 6 years ago

Thanks for the reviewing and feedbacks 👍 @jbeezley