search

Kitware / minerva

Minerva: client/server/services for analysis and visualization
Apache License 2.0
36 stars 14 forks source link

Dataset name text filtering #485

Closed matthewma7 closed 6 years ago

matthewma7 commented 6 years ago

2018-01-30_15-08-33

aashish24 commented 6 years ago

@matthewma7 @manthey as discussed in the meeting, we would like to extend it to search through the metadata as well. Are we planning on doing that in this branch or another one?

matthewma7 commented 6 years ago

@aashish24 I personally is thinking to do it in another PR because we kind want this to release soon, and I also have a concern that searching meta may end up with too many records, so some mechanism to indicate might be needed (a checkbox, a sorted result, etc)

aashish24 commented 6 years ago

@aashish24 I personally is thinking to do it in another PR because we kind want this to release soon, and I also have a concern that searching meta may end up with too many records, so some mechanism to indicate might be needed (a checkbox, a sorted result, etc)

Sounds good. We should start tagging releases (thoughts?)

aashish24 commented 6 years ago

@matthewma7 @manthey how do we enable coverage reporting on PR's?

manthey commented 6 years ago

Girder changed where coverage files are stored. I just made PR #487 to fix the reporting.

matthewma7 commented 6 years ago

@manthey Thank you for the review all the edge case you found.

manthey commented 6 years ago

:+1: