Kitware / minerva

Minerva: client/server/services for analysis and visualization
Apache License 2.0
36 stars 14 forks source link

Infoviz widget #502

Closed matthewma7 closed 6 years ago

matthewma7 commented 6 years ago

This PR implements an InfovizWidget to visualize a dataset. The requires a vector dataset with a visualizing numeric property, otherwise, a soft error message will be thrown.

2018-04-12_10-12-24

jeffbaumes commented 6 years ago

Cool. The transparency makes things look cluttered to me. Not sure if having it in a transparent state when not focused is a great feature. Otherwise this looks nice.

matthewma7 commented 6 years ago

@jeffbaumes I see. And transparency is kind of out of fashion nowadays. I think I'll remove the transparency for now. @Everyone image

manthey commented 6 years ago

If I pick two datasets, I find it confusing that the two panels appear directly atop one another. Perhaps we should stagger them down by roughly the height of the title bar?

Also, should picking a dataset that is already be shown do anything? Like bring that window to the top?

matthewma7 commented 6 years ago

@manthey Those are great suggestions. I implemented them, please take a look at the latest commit.

Preview: image

manthey commented 6 years ago

The staggered position is a lot better. What determines the z-order of new panels? If I open multiple panels, then close some of them, then reopen the ones I closed, sometimes the reopened panels appear behind the existing panels.

When opening multiple panels, should their initial position be related to their position in the datasets list? I think currently they are positioned in the order that the data is finished fetching.

matthewma7 commented 6 years ago

The z-order is controlled by jquery Dialog, but I think there are ways to tell it to do what you described, I'll take a look later.

matthewma7 commented 6 years ago

Hi @manthey, I implemented the way you suggested, please take another look.

matthewma7 commented 6 years ago

@manthey Thank you for your review of all recent PRs. 👍