Closed matthewma7 closed 6 years ago
Cool. The transparency makes things look cluttered to me. Not sure if having it in a transparent state when not focused is a great feature. Otherwise this looks nice.
@jeffbaumes I see. And transparency is kind of out of fashion nowadays. I think I'll remove the transparency for now. @Everyone
If I pick two datasets, I find it confusing that the two panels appear directly atop one another. Perhaps we should stagger them down by roughly the height of the title bar?
Also, should picking a dataset that is already be shown do anything? Like bring that window to the top?
@manthey Those are great suggestions. I implemented them, please take a look at the latest commit.
Preview:
The staggered position is a lot better. What determines the z-order of new panels? If I open multiple panels, then close some of them, then reopen the ones I closed, sometimes the reopened panels appear behind the existing panels.
When opening multiple panels, should their initial position be related to their position in the datasets list? I think currently they are positioned in the order that the data is finished fetching.
The z-order is controlled by jquery Dialog, but I think there are ways to tell it to do what you described, I'll take a look later.
Hi @manthey, I implemented the way you suggested, please take another look.
@manthey Thank you for your review of all recent PRs. 👍
This PR implements an InfovizWidget to visualize a dataset. The requires a vector dataset with a visualizing numeric property, otherwise, a soft error message will be thrown.