Closed jbeezley closed 8 years ago
Makes sense that it would cause an error - there's no 'body' yet. I'll see if I can just substitute 'head'...
ParaViewWeb script might need to be inside body. Not sure why though.
On Thu, Jul 7, 2016 at 10:28 AM, aronhelser notifications@github.com wrote:
Makes sense that it would cause an error - there's no 'body' yet. I'll see if I can just substitute 'head'...
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Kitware/paraviewweb/issues/159#issuecomment-231094449, or mute the thread https://github.com/notifications/unsubscribe/AAR-doQccUjZ5OlEwAO6_uvPfpbJB73Fks5qTQ0OgaJpZM4JHIOz .
Using document.head.style seems to be working fine. Should go in with next HistogramSelector features.
This is admittedly pathological, but does it still work if there is no head
? Is there any reason executing this function can't be deferred until a HistogramSelector is actually instantiated?
OK, I can defer it. I also used either head or body, with a fallback. Thanks for the feedback.
On Fri, Jul 8, 2016 at 1:07 PM, Jonathan Beezley notifications@github.com wrote:
This is admittedly pathological, but does it still work if there is no head? Is there any reason executing this function can't be deferred until a HistogramSelector is actually instantiated?
— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/Kitware/paraviewweb/issues/159#issuecomment-231416291, or mute the thread https://github.com/notifications/unsubscribe/AS_pnc3SNqk5pkdnIk4PV5pT0w3-WOYuks5qToPsgaJpZM4JHIOz .
The following html results in the error
Cannot read property 'style' of null
when loading:It seems to be originating from this line: src/InfoViz/Native/HistogramSelector/index.js#L42. It does load successfully if I move the script tag into the body.