Vagrant up fails when only 1 CPU

Kitware / paraviewweb

Web framework for building interactive visualization relying on VTK or ParaView to produce visualization data

http://kitware.github.io/paraviewweb/

BSD 3-Clause "New" or "Revised" License

163 stars 50 forks source link

Vagrant up fails when only 1 CPU #404

Closed Trophime closed 6 years ago

Trophime commented 6 years ago

When trying to create a VM using vagrant, there is a problem on machines with only 1 cpu. Indeed in VagranFile cpus = cpus / 2 will return 0 which seems to be problematic for vagrant

jourdain commented 6 years ago

Thanks for your feedback. I guess the goal was to prevent using too much resources from the host system. Maybe we should just set it to 1.

Trophime commented 6 years ago

cpus = [cpus /2, 1].max would do the trick?

jourdain commented 6 years ago

do you meam [].max ? Since it can be between 0 and 1.

Trophime commented 6 years ago

it should return either cpus/2 or 1...

Trophime commented 6 years ago

it seems to work for me cpus = [cpus /2, 1].max

jourdain commented 6 years ago

Great just push some changes to fix it...

jourdain commented 6 years ago

Thanks for your feedback...