search

Kitware / paraviewweb

Web framework for building interactive visualization relying on VTK or ParaView to produce visualization data
http://kitware.github.io/paraviewweb/
BSD 3-Clause "New" or "Revised" License
160 stars 50 forks source link

Update pvw build system #496

Closed scottwittenburg closed 5 years ago

scottwittenburg commented 5 years ago

This updates to the latest kw-web-suite, but ignores some new style rules which generate too many issues to fix at the moment. Also updates to react-dom:16.4.2 to fix a vulnerability.

scottwittenburg commented 5 years ago

@jourdain updating to kw-web-suite:8.0.0 resulted in over 2K new lint errors and running eslint with --fix said it was only going to be able to fix 71 of them. I started fixing them manually, but then reverted and just disabled some of the rules, because it seems like it will take a decade.

But let me know if some of those rules I disabled should actually be addressed.

jourdain commented 5 years ago

disabling rules for now is good.

scottwittenburg commented 5 years ago

Since everything's green, we could merge, unless you see anything you want changed.

jourdain commented 5 years ago

:tada: This PR is included in version 3.2.7 :tada:

The release is available on:

Your semantic-release bot :package::rocket: