search

Kitware / react-vtk-js

Declarative library exposing vtk.js visualization pipeline as React components
https://kitware.github.io/react-vtk-js/
77 stars 24 forks source link

Reslice mapper representation #112

Open sankhesh opened 1 year ago

sankhesh commented 1 year ago

Exposes the vtk-js vtkImageResliceMapper as a representation in react-vtk-js

sankhesh commented 1 year ago

Depends on https://github.com/Kitware/vtk-js/pull/2839

sankhesh commented 1 year ago

@floryst @jadh4v

floryst commented 1 year ago

Overall LGTM. Still haven't tested it. Will port over to beta when this is merged.

floryst commented 1 year ago

I see 2839 has been merged. Once this PR has been updated, I will test it out.

sankhesh commented 1 year ago

Do I need to modify the minimum vtk-js version or will the latest be automatically pulled? The new release puts vtk-js at v28.2.1

floryst commented 1 year ago

The package-lock.json will need to be updated with an npm install. It's currently on 28.2.0.

Also, I just realized this is a breaking change, since we are requiring a new major version of vtk.js as a dependency. In that case, I'll rewrite this with your input onto the beta branch. Once that's done, we can close this instead of merging.