search

Kitware / react-vtk-js

Declarative library exposing vtk.js visualization pipeline as React components
https://kitware.github.io/react-vtk-js/
77 stars 24 forks source link

Fix setRange call to vtkDataArray for single component arrays #117

Closed jadh4v closed 1 year ago

jadh4v commented 1 year ago

Fix setRange call to vtkDataArray for single component arrays.

There may be cases (such as here) where an explicit call is made to vtkDataArray::getRange(range, 0) with index === 0. This can trigger unexpected call to computeRange if setRange isn't called with index === 0 before.

floryst commented 1 year ago

Oh, I didn't realize you were looking into this from the react-vtk-js side. This was fixed in vtk.js proper: https://github.com/Kitware/vtk-js/pull/2872

floryst commented 1 year ago

LGTM!

jourdain commented 1 year ago

:tada: This PR is included in version 2.0.0-beta.10 :tada:

The release is available on:

Your semantic-release bot :package::rocket: