Kitware / react-vtk-js

Declarative library exposing vtk.js visualization pipeline as React components
https://kitware.github.io/react-vtk-js/
77 stars 24 forks source link

Improve usage examples #54

Closed osiux closed 2 years ago

osiux commented 2 years ago

Hi! I'm debugging some things with the lib and wanted to use the examples for this, but building or using it for dev (npm run dev inside usage) was taking so much time, so I made a few changes:

Only difference I see at first glance from current examples is with the Geometry/PolyDataViewer, but not sure if current one is fine or new one is how it should look. If new one is wrong and you like this change I can try to find what is happening.

Note: This is not a must have change, but it's been pretty helpful to me while testing the library with the examples.

Current: image

New: image

floryst commented 2 years ago

I did a quick passthrough, and it looks reasonable to me. Off the top of my head, the differences in the PolyDataViewer seem to be related to whichever representation configuration is set. I'm good to merge this and figure that out later, since it's not that much of a critical thing in my opinion.

jourdain commented 2 years ago

I let you handle the merge @floryst since you are playing with that project more lately. ;-)

jourdain commented 2 years ago

:tada: This PR is included in version 1.11.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: