search

Kitware / react-vtk-js

Declarative library exposing vtk.js visualization pipeline as React components
https://kitware.github.io/react-vtk-js/
77 stars 24 forks source link

Added focalPoint as prop and setting on update #66

Closed jun-sironamedical closed 2 years ago

jun-sironamedical commented 2 years ago

Issue: focalPoint is reset due to resetCamera call for each position update. I added focalPoint as prop, and setting it after resetCamera, to retain focalpoint.

line 465 if (previous) { this.resetCamera(); }

jun-sironamedical commented 2 years ago

Not sure why we need to call cameraReset every positional update but I tried to keep everything the same. Have concern on moving the order of operation to resetCamera and then setCamera, but if my logic is correct, the only difference should be focalPoint is retained.

jourdain commented 2 years ago

:tada: This PR is included in version 1.13.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: