search

Kitware / react-vtk-js

Declarative library exposing vtk.js visualization pipeline as React components
https://kitware.github.io/react-vtk-js/
77 stars 24 forks source link

Updating pin of react #75

Open WesleyTheGeolien opened 2 years ago

WesleyTheGeolien commented 2 years ago

Hi guys,

I’m not too familiar with all the react ins and outs but when installing react-vtk-us in my project that is on react 17.X I am getting an incompatible versions errors.

Apparently this is due to my npm / node version? I can get around this by specifying —legacy-peer-deps but I believe that will be on all my packages and not just react-vtk-js.

I also tried forking and updating the pin to 16 || 17 https://github.com/Kitware/react-vtk-js/commit/5f9a91dda738005e2f224de1dd2c60fe96462624

this seems to work in initial testing at least for the errors. Is there a reason this wouldn’t work long term?

I saw #67 but am. It entirely sure this is the same thing?

floryst commented 2 years ago

Right now react-vtk-js is strictly react v16, unfortunately. #67 is related to this issue. We haven't been able to test react-vtk-js with v17 or v18. FYI efforts in #71 will help address this.

FYI @jourdain

jourdain commented 2 years ago

react-vtk-js could move to a newer version of react but it needs to remains compatible with react@16 so it can be used by Dash.

WesleyTheGeolien commented 2 years ago

Ok thanks for the update on this guys