search

Kitware / react-vtk-js

Declarative library exposing vtk.js visualization pipeline as React components
https://kitware.github.io/react-vtk-js/
77 stars 24 forks source link

use Name instead of array for removal #77

Closed WesleyTheGeolien closed 2 years ago

WesleyTheGeolien commented 2 years ago

This fix should allow the correct unmounting of DataArrays and their removal from the fields context.

Linked to #76

jourdain commented 2 years ago

Can you rename your commit so the CI can handle change-log and release?

fix(DataArray): remove array at unmount correctly

WesleyTheGeolien commented 2 years ago

Can you rename your commit so the CI can handle change-log and release?

fix(DataArray): remove array at unmount correctly

Should be done.

Could you setup something like husky in the vtk-js repo so these things could be handled at commit time rather than amending posteriori?

jourdain commented 2 years ago

Your PR has 3 commits but since only 1 really matter it would be fine. We use husky on other projects but didn't get the chance to set it up on that repo.

Thanks for your contribution!

jourdain commented 2 years ago

:tada: This PR is included in version 1.13.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: