search

Kitware / react-vtk-js

Declarative library exposing vtk.js visualization pipeline as React components
https://kitware.github.io/react-vtk-js/
77 stars 24 forks source link

fix(XMLWriter): Bunp vtk.js version to fix crash when using XMLWriter #92

Closed tamaynard closed 1 year ago

tamaynard commented 1 year ago

Getting "Uncaught TypeError: pako__WEBPACK_IMPORTED_MODULE_1__.default.deflate is not a function" when attempting to use XMLWriter. Bumping should fix this.

tamaynard commented 1 year ago

Yes, I just followed the procedure as in https://github.com/Kitware/react-vtk-js/commit/7fc434c795bd3b0d61b58e6345d4654d972fc556 to update vtk.js. I tested against the latest versions of node and npm and didn't find any issues.

floryst commented 1 year ago

I think this might be due to react-vtk-js still inadvertently bundling parts of vtk.js. In any case, the changes look fine for now, but there's still an underlying issue.

jourdain commented 1 year ago

:tada: This PR is included in version 1.15.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

tamaynard commented 1 year ago

Yes it's not ideal at all. But for now this was the path of least resistance.