search

Kitware / tangelo

A simple, quick, powerful web framework
http:/tangelohub.org/tangelo/
Apache License 2.0
185 stars 35 forks source link

Improve coverage testing #455

Closed waxlamp closed 9 years ago

waxlamp commented 9 years ago

This PR contains the following changes:

@jeffbaumes let me know if this is ok in general, and on your mac in particular.

jeffbaumes commented 9 years ago

Nice, I'll run it in the morning. On Tue, Dec 16, 2014 at 3:55 PM Roni Choudhury notifications@github.com wrote:

This PR contains the following changes:

  • coverage is run for all targeted files, resulting in zero coverage for untested files
  • the bundled plugin files have been added to the list of tested files
  • cross-platform (to Windows, anyway) support has been improved

@jeffbaumes https://github.com/jeffbaumes let me know if this is ok in

general, and on your mac in particular.

You can merge this Pull Request by running

git pull https://github.com/Kitware/tangelo fix-coverage

Or view, comment on, or merge it at:

https://github.com/Kitware/tangelo/pull/455 Commit Summary

  • Fixing serious error in setting up inclusion paths for coverage testing
  • General improvements to coverage testing.
  • "Universal newlines" splitting so this works cross-platform
  • Fixing tangeloCmdLine so it works on windows

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/Kitware/tangelo/pull/455.

jeffbaumes commented 9 years ago

LGTM! Worked fine on my mac.

jeffbaumes commented 9 years ago

LGTM

waxlamp commented 9 years ago

Hmmm... I may have to start using "live long and prosper" in place of "looks good to me" :alien: