search

Kitware / trame-client

Internal client side implementation of trame
MIT License
7 stars 6 forks source link

No indication of minimum Python version #20

Open DManowitz opened 8 months ago

DManowitz commented 8 months ago

There is no python_requires in your setup.py or setup.cfg, but there is Python 3.8 code in at least trame_client\utils\web_module.py. Admittedly, Python 3.7 is EOL now, but it may still be used in some places, and there may be similar issues when transitioning between minimum supported Python versions in the future.

jourdain commented 8 months ago

Ideally trame* should be 3.6 compatible, but indeed, that file has some 3.8 assumption. Also that file is not a true requirement of trame. It will be more for the users of it.

The true bump which should force a python_requires would be related to some asycnio api update. But those should not happen anytime soon.

From your point of you, do you think we should provide a python_requires=>=3.8 or fix that file to be EOL 3.6 compatible? (We do have users still in 3.6)

DManowitz commented 8 months ago

I'd say that if trame as a whole is claiming to be 3.6 compatible, then there should be a fix to make this 3.6 compatible. I might also want to put a python_requires>=3.6 (unless that is not actually 3.6 compatible) as a reminder when you decide to increase the minimum supported version of Python.

DManowitz commented 8 months ago

Also, you might want to make sure your documentation mentions the minimum required Python version.