Open banesullivan opened 10 months ago
If instead I build my own JupyterLab docker image, all works fine:
FROM python:3.11-slim
# Set non-root user
ARG NB_USER=jovyan
ARG NB_UID=1000
ENV USER ${NB_USER}
ENV NB_UID ${NB_UID}
ENV HOME /home/${NB_USER}
ENV PATH="/home/${NB_USER}/.local/bin:$PATH"
RUN adduser --disabled-password \
--gecos "Default user" \
--uid ${NB_UID} \
${NB_USER}
WORKDIR ${HOME}
USER ${NB_USER}
RUN pip install trame trame_vtk trame_vuetify trame_jupyter_extension
EXPOSE 8888
ENTRYPOINT [ "jupyter", "lab" ]
CMD ["--port=8888", "--no-browser", "--ip=0.0.0.0"]
FYI, it should be pip install trame trame-vtk trame-vuetify trame_jupyter_extension
I'm about 90% sure it doesn't matter as pip
will resolve -
or _
as the same when installing from PyPI. Is there an edge case I'm missing? I'm searching around but can't find a PEP outlining this...
if so, I feel like the distribution name for this package should be changed to match the convention set by the rest of the Trame ecosystem
Also FWIW, PyPI shows it as:
and if we look at the wheel files on PyPI for a package like trame-vtk
the distname is converted to underscores: https://pypi.org/project/trame-vtk/#files
Yes, I got confused from the generated readme... We should use -
.
Maybe this provides some insight? I pip freeze
in both images and this is the diff:
I can't quite pin down the reason this is failing, but using the
jupyter/base-notebook:python-3.10
base docker image, the examples here fail to work with a JS console error of:Originally found in https://github.com/pyvista/pyvista/pull/5288
To reproduce, use this Dockerfile:
Then run the example:
examples/test_trame_jupyter_comm.ipynb