search

Kitware / trame-jupyter-extension

Jupyter extension for trame client/server communication
BSD 3-Clause "New" or "Revised" License
10 stars 0 forks source link

Cross origin issue with latest release, breaking other widgets #7

Closed banesullivan closed 5 months ago

banesullivan commented 5 months ago

6191d2d seems to have broken use of trame with jupyter-server-proxy and is affecting other third party libraries.

After installing trame-jupyter-extension==2.1.1, I see chrome-error://chromewebdata/ when trying to use trame over jupyter-server-proxy

Further, this is affecting other thrid party software. For instance, if I try to use ipyleaflet at all after this upgrade, I see net::ERR_BLOCKED_BY_RESPONSE.NotSameOriginAfterDefaultedToSameOriginByCoep errors when loading any basemap tiles

from ipyleaflet import Map
Map()
Screenshot 2024-06-16 at 10 55 25 PM

Downgrading to trame-jupyter-extension==2.1.0 yields correct behavior

jourdain commented 5 months ago

yes... We will need to go the route of service worker to properly enable WASM... I may push a temporary fix that only enable those cross origin option with some ENV vars...

jourdain commented 5 months ago

Should be fixed in 2.1.2

jourdain commented 5 months ago

For reference https://web.dev/articles/coop-coep

jourdain commented 5 months ago

Ideally leaflet should take some extra args to allow the fetching of the tiles/images...