Kitware / trame-router

trame-router brings Vue Router capabilities into trame widgets and ui
MIT License
1 stars 1 forks source link

Some issues with Vue Router's Named Views #2

Closed davidangelesu closed 6 months ago

davidangelesu commented 6 months ago

Hi there, I am having some issues with utilizing Named Vue's (maybe I might be trying to do something that is currently not supported)

I am currently defining some RouterViewLayout's:

 with RouterViewLayout(server, "/",name="Sidebar"):
    with vuetify.VCard():
        vuetify.VCardTitle("This is Sidebar")

with RouterViewLayout(server, "/", name="Content"):
    with vuetify.VCard():
        vuetify.VCardTitle("This is Content")

and I am trying to load a specific View in the drawer and another one in the Sidebar

with SinglePageWithDrawerLayout(server) as layout:
    layout.title.set_text("Multi-View demo")

    with layout.content:
        with vuetify.VContainer():
            router.RouterView(name="Content")

    with layout.drawer:
        router.RouterView(name="Sidebar")

After some debugging it seems that the issue comes from the name parameter that i am passing to the RouterView is not being taken into consideration

jourdain commented 6 months ago

The name part for the router was never added, but it should be easy to enable.

jourdain commented 6 months ago

Are you using vue3 or vue2?

davidangelesu commented 6 months ago

Hi, I am currently using vue2

On Sun, Mar 24, 2024, 00:58 Sebastien Jourdain (Kitware) < @.***> wrote:

Are you using vue3 or vue2?

— Reply to this email directly, view it on GitHub https://github.com/Kitware/trame-router/issues/2#issuecomment-2016635607, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACD2CURNW3DMU7HDQRG2FMDYZYJKRAVCNFSM6AAAAABFEWHNYCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJWGYZTKNRQG4 . You are receiving this because you authored the thread.Message ID: @.***>

jourdain commented 6 months ago

Fixed in v2.2.0

davidangelesu commented 6 months ago

Amazing! thanks

On Sun, Mar 24, 2024, 21:54 Sebastien Jourdain (Kitware) < @.***> wrote:

Fixed in v2.2.0

— Reply to this email directly, view it on GitHub https://github.com/Kitware/trame-router/issues/2#issuecomment-2016939993, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACD2CURXJOWXJE4SVEQVA33YZ44RHAVCNFSM6AAAAABFEWHNYCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJWHEZTSOJZGM . You are receiving this because you authored the thread.Message ID: @.***>