Kitware / trame-vtk

VTK/ParaView widgets for trame
BSD 3-Clause "New" or "Revised" License
17 stars 8 forks source link

fix(serializer): Better handling of actor user matrix #51

Closed user27182 closed 1 year ago

user27182 commented 1 year ago

Resolves #50

jourdain commented 1 year ago

trame_vtk/modules/vtk/serializers/actors.py:3:1: F401 'vtkmodules.vtkCommonMath.vtkMatrix4x4' imported but unused

jourdain commented 1 year ago

FYI, the new version of PyVista is changing its initial camera point of view? That led me to update a baseline. But both local and remote are consistent so I feel confident.

But, the local rendering of volume rendering is now broken with PyVista. (FYI @banesullivan, @alesgenova)

banesullivan commented 1 year ago

new version of PyVista is changing its initial camera point of view

I'm not aware of this... and I hope not the case. Not sure what you are referring to.

jourdain commented 1 year ago

New PyVista new

vs old PyVista

old

user27182 commented 1 year ago

New PyVista vs old PyVista

@jourdain Can you please clarify which versions of old and new you are referring to?

A bug with the orientation/direction of pyvista.Sphere was recently patched and released in PyVista 0.42, I believe, with PR pyvista#4674. This resulted in scalar values being plotted differently for pyvista.Sphere objects, and similar regression test images had to be updated accordingly. The changes are shared below (see direct link here).

Perhaps this is the same cause of the differences you're seeing with the trame PyVista tests? Though in your image the spheres appear to be mirrored, whereas the image below looks more like a 90 degree rotation.

image
jourdain commented 1 year ago

When running python ./examples/validation/PyVistaInt64.py with

vtk                  9.2.6
pyvista              0.40.1

I get
Screenshot 2023-10-10 at 8 20 48 AM

Then with pyvista==0.42.3, I get

Screenshot 2023-10-10 at 8 21 14 AM

jourdain commented 1 year ago

Just had to update our test baseline