search

Kitware / trame-vtk

VTK/ParaView widgets for trame
BSD 3-Clause "New" or "Revised" License
17 stars 8 forks source link

v2.8.4 breaks compatability with Python 3.8 #63

Closed MatthewFlamm closed 9 months ago

MatthewFlamm commented 9 months ago

6e163d6 broke PyVista compatibility with Python 3.8. See https://github.com/pyvista/pyvista/actions/runs/7914881477/job/21605549677?pr=5625

[large traceback shortened]
    File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/trame_vtk/modules/vtk/serializers/data.py", line 29, in polydata_serializer
      points = get_array_description(
    File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/trame_vtk/modules/vtk/serializers/helpers.py", line 76, in get_array_description
      p_md5 = digest(array)
    File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/trame_vtk/modules/vtk/serializers/helpers.py", line 51, in digest
      record = {"sha": hash_data_array(array), "mtime": array.GetMTime()}
    File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/trame_vtk/modules/vtk/serializers/utils.py", line 51, in hash_data_array
      hashed_bit = hashlib.md5(memoryview(data_array), usedforsecurity=False).hexdigest()
  TypeError: openssl_md5() takes at most 1 argument (2 given)

Edit: I should be more precise in saying that it breaks PyVista functionality when using trame-vtk.

jourdain commented 9 months ago

@MattTheCuber

MattTheCuber commented 9 months ago

@MattTheCuber

Oops! That's my bad.