search

Kitware / vaui

Apache License 2.0
8 stars 1 forks source link

Annotation info click #19

Closed matthewma7 closed 6 years ago

matthewma7 commented 6 years ago

Implement a feature to show annotation information in a right sidebar

aashish24 commented 6 years ago

it works for me. Only one minor thing I noted at the run time is when I clicked at a non-box location, I see 0 being displayed in the info panel. Perhaps we should not display 0?

matthewma7 commented 6 years ago

@mwoehlke-kitware Frankly, I have been px exclusively in other projects and base girder. The px are density-independent pixels nowadays. Browsers don't provide the old font-size based zooming anymore (at least can't be found easily), I am aware there are arguments around em, rem, px. em etc. em is relative to the element font-size setting, which changes(compare to px or rem), so it adds one layer of complexity. Basically, I never found a shortcoming of using px. I am not seeing the benefit of using em over px.

mwoehlke-kitware commented 6 years ago

Browsers don't provide the old font-size based zooming anymore

Firefox does. I tested with it, and it causes Bad Things to happen. Moreover, I have a philosophical objection to preventing the user from changing their text size and/or unnecessarily penalizing users that do so.

Using px exclusively instead of text-based units where appropriate is basically saying "(redacted) you" to users that might want or need to use larger text.

aashish24 commented 6 years ago

@matthewma7 @mwoehlke-kitware lets only address / report issue concerning with timeout ( clearTimeout(this._annotationEventHandle); I would not like to do anything else on this branch unless we have a bug in normal view of any browser. Otherwise I would like it to be merged. I will create an item for other items for discussions next week.