search

Kitware / vaui

Apache License 2.0
8 stars 1 forks source link

New clip explorer #30

Closed matthewma7 closed 6 years ago

matthewma7 commented 6 years ago

This PR implements a dedicated clip selector to provide better user experience and feature.

However, this would have performance problem when there are a large number of folders at the same level This would also incorrectly mark video clip folder as a common folder if the folder contains more than 9 non-image frame items.

aashish24 commented 6 years ago

@Matthewma7 thanks. Lets discuss this somw more tomorrow.

mwoehlke-kitware commented 6 years ago

FYI:

(vaui.min.js:2619:7)
Warning: Unsupported style property text-align. Did you mean textAlign?

Check the render method of `ClipExplorer`.

(jquery.js:3860)
jQuery.Deferred exception: items[0] is undefined downloadItemByName/<@http://localhost:8080/static/built/plugins/vaui/vaui.min.js:11281:13
mightThrow@http://localhost:8080/static/built/girder_lib.min.js:4019:21
resolve/</process<@http://localhost:8080/static/built/girder_lib.min.js:4087:12
matthewma7 commented 6 years ago

@mwoehlke-kitware New code has been committed. Thanks, I noticed the warnings. The jquery one is fine, it is simply jquery will write a warning when there is a rejected promise.