search

Kitware / vaui

Apache License 2.0
8 stars 1 forks source link

Implement track (state) removal functionality #36

Closed mwoehlke-kitware closed 6 years ago

mwoehlke-kitware commented 6 years ago

This implements low-level mechanisms (i.e. in AnnotationGeometryContainer) for removing geometries and entire tracks. These are not yet in use. It does not necessarily need to be merged anywhere in its current state, but I am pushing it now because the relevant code has been subject to frequent and heavy modification lately.

matthewma7 commented 6 years ago

Hi @mwoehlke-kitware, before you get further dependant on these changes I would like to frankly say that I don't think it's time for the refactoring in these changes. Could we work on new features and apply only necessary changes to existing code. If you think some refactoring is necessary let's discuss it before making the changes. I see the reason you might want to have some refactoring, but if the current organization works fine for the new features, I would say let's keep it intact. I'll leave some comment on the code inline.

mwoehlke-kitware commented 6 years ago

Removal of states is now implemented and seems to be working. Removal of entire tracks is pending (partly due to interaction with activities). Note that I had to refactor the low-level code because Javascript can't use objects as Map keys.