Kitware / wslink

Python/JavaScript library for communicating over WebSocket
https://kitware.github.io/wslink/
BSD 3-Clause "New" or "Revised" License
83 stars 26 forks source link

fix(ws_server): handle client disconnection even in case of error #120

Closed eino closed 2 years ago

eino commented 2 years ago

Add a try/finally to delete client connection even in case it happens via an exception.

fix #118

jourdain commented 2 years ago

LGTM minus conflict resolution. Is it ready to merge once you resolved the conflict?

eino commented 2 years ago

Resolved the conflict and tested once again, it's good to merge :+1:

jourdain commented 2 years ago

:tada: This PR is included in version 1.8.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket: