NameError: name 'pub' is not defined

Kitware / wslink

Python/JavaScript library for communicating over WebSocket

https://kitware.github.io/wslink/

BSD 3-Clause "New" or "Revised" License

83 stars 26 forks source link

NameError: name 'pub' is not defined #146

Closed skycloud1030 closed 1 year ago

skycloud1030 commented 1 year ago

Describe the bug

NameError: name 'pub' is not defined after https://github.com/Kitware/wslink/commit/ffd269d152abec57b8590f3c7e52172eb9841c91
Have to modify the missing import in the code (e.g. https://github.com/Kitware/wslink/blob/master/python/src/wslink/protocol.py#L428)

wslink version: v.11.2

jourdain commented 1 year ago

Thanks for reporting the issue. Sorry about that. Should be fixed soon.

jourdain commented 1 year ago

:tada: This issue has been resolved in version 1.11.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

JJIASI commented 1 year ago

@jourdain
I tried using v1.11.3, and I encountered another error.

...
  File "/app/venv/lib/python3.9/site-packages/wslink/protocol.py", line 353, in onMessage
    self.pub_manager.EXCEPTION_ERROR,
AttributeError: 'PublishManager' object has no attribute 'EXCEPTION_ERROR'

Seems static variables are outside of class PublishManager. 🤔 https://github.com/Kitware/wslink/blob/v1.11.3/python/src/wslink/publish.py#L73-L78

jourdain commented 1 year ago

Oups...

jourdain commented 1 year ago

v1.11.4 will fix it. I could reproduce the issue locally, so now, I'm sure that my fix solved that issue.

Thanks again for reporting back here.