search

Kitware / wslink

Python/JavaScript library for communicating over WebSocket
https://kitware.github.io/wslink/
BSD 3-Clause "New" or "Revised" License
83 stars 26 forks source link

fix(unchunker): initial allowed message size to env var #158

Closed kliment-slice closed 5 months ago

kliment-slice commented 5 months ago

When sending a JWT token along with a message, this size ends up too small and results in a ValueError. This PR increases max_message_size to 3000 to accommodate.

fix #157

jourdain commented 5 months ago

While I'm not against bumping that initial message size, I want to make sure it is actually needed (see my comment on the issue).

Also can you reword your commit so it could trigger a new release/change log accordingly.

fix(unchunker): increase initial allowed message size

jourdain commented 5 months ago

Thanks for the change but since your commit message does not respect semantic release, I can not merge it. If I were to merge it as-is, no release will be created (and the point of your PR will be lost).

jourdain commented 5 months ago

I guess I'll squash your changes and rewrite your commit. (I always forgot that I can simply do it via github...)

jourdain commented 5 months ago

:tada: This PR is included in version 2.0.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket: