search

Kitware / wslink

Python/JavaScript library for communicating over WebSocket
https://kitware.github.io/wslink/
BSD 3-Clause "New" or "Revised" License
83 stars 27 forks source link

Remove secret from logs #99

Closed eino closed 2 years ago

eino commented 2 years ago

Hi,

The server is logging secrets when logging rpc messages. This is problematic from a security perspective, as it could potentially leak sensitive access tokens.

As logging the incoming rpc can still be handy I propose a PR to address this issue by replacing any "secret"-named argument by stars in the logged message. What do you think of this solution?

Regards,

jourdain commented 2 years ago

:tada: This issue has been resolved in version 1.6.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: